[MPlayer-dev-eng] [PATCH] VDA support for mplayer

Xunzhen Quan quanxunzhen at gmail.com
Wed Jul 18 14:50:49 CEST 2012

On Wed, Jul 18, 2012 at 8:27 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Xunzhen Quan <quanxunzhen <at> gmail.com> writes:
> > Attachment (h264_vda_ffmpeg.diff): application/octet-stream, 9 KiB
> Given that the MPlayer-part of the patch is trivial,
> please send the patch to ffmpeg-devel, consider fixing one issue:

Should these two patches both be sent to ffmpeg-devel?

> -typedef struct {
> > +typedef struct _vda_frame {
> Why is this needed?
> Names starting with underlines are not allowed (they are
> reserved), please choose another name.

Remove the leading underscore seems ok, I'll fix that.

I do that just because there is a pointer in the struct refer to itself,
and it may lead to some compiler warning if no name there.

More information about the MPlayer-dev-eng mailing list