[MPlayer-dev-eng] [PATCH] stream_dvd: include audio and sub track type.

[Alexander Strasser]

Hi,

Ingo Brückl wrote:
> Nicolas George wrote on Sun,  8 Jul 2012 16:01:05 +0200:
> 
> > +static const char *const dvd_audio_stream_subtype[] = {
> > +    "generic", "normal", "impaired", "comments", "comments (bis)",
> > +};
> 
> > +        char subtype[64] = "unknown";
> 
> > +        if (subtitle->code_extension < 16) {
> > +            static const char *const high[] =
> > +                { "normal", "closed captions", "forced", "commentary" };
> > +            static const char *const low[] =
> > +                { "undefined", "content", "large", "children" };
> > +            snprintf(subtype, sizeof(subtype), "%s, %s",
> > +                high[subtitle->code_extension >> 2],
> > +                low [subtitle->code_extension &  3]);
> > +        }
> 
> These should be translatable.

  IMHO translating those would hurt programmatic use in conjunction
with _IDENTIFY type messages.

  OTOH it is also used by the _STATUS-level messages. Maybe a mapping
could be introduced for differentiating the canonical vs the translated
version? Not sure it is really worth the added complexity though, which
would be quite a bit of work given how the patch implements the feature
currently.

  Also since we do not know any better we do not expect those fields to
usually give much information anyway. Please correct me if you do know
better.

  Alexander