[MPlayer-dev-eng] [PATCH]Fix FFmpeg tiff RGBA on big endian

[Carl Eugen Hoyos]

Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:

> On Sun, Jan 22, 2012 at 11:42:10PM +0000, Carl Eugen Hoyos wrote:
> > Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> > 
> > > > Attached fixes playback of RGBA tiff on BE.
> > > > Alternative might be to completely remove RGB32 and friends but this
> > > > is the smaller patch...

Patch applied.

> > > What do you mean by the "completely remove" part?
> > 
> > Remove all RGB32 and BGR32 and replace with RGBA, ARGB, BGRA and ABGR.
> > But I would prefer not to do that atm.
> 
> The idea is to have exactly those that FFmpeg actually supports.

We are currently missing 64bit rgb (which works fine with opengl), I wonder if
changing "|64" in libmpcodecs/img_formats.h (and vo_x11.c) to "|128" hast any
side-effects?
Any other vos that support this "rgb endian-swapping"?

> If you removed RGB32 for example you'd have to add both RGBA and
> ABGR (or was it ARGB and BGRA? Whatever) despite the fact that
> only even one will ever work with a certain MPlayer build.

I do not plan to remove them, I just wondered if that would be possible.

> That seems to me like making stuff more complicated and increasing
> the risk that it will only work on little-endian with not really
> much of a benefit I can see.

Agreed,

Carl Eugen