[MPlayer-dev-eng] [PATCH] YellowBlue/AmberBlue Dubios support for stereo3d

[Reimar Döffinger]

On Tue, Jan 17, 2012 at 10:39:14PM +0100, Bob wrote:
> Tinkering with this filter, I realized that there is most likely a
> large room for improvement in speed and gama/hue corrections, but
> works for simple material.

What do you need to do that you can't just use (if necessary on the
code reuse level) -vf eq2?
And I am sure some of the people on the list who might be employed
at overly paranoid companies would appreciate if you didn't
mention patent numbers.
And another good part probably don't see why you should care,
considering that MPlayer already uses FFmpeg, a good number of
countries don't have software patents and even then it is questionable
whether they can be enforced on source code.

> -     {    0,     0, 65536,     0,     0,     0}}
> +     {    0,     0, 65536,     0,     0,     0}},
> +    {{65535,-12650,18451,   -987, -7590, -1049},    //ANAGLYPH_YB_DUBOIS
> +     {-1604, 56032, 4196,    370,  3826, -1049},
> +     {-2345,-10676, 1358,   5801, 11416, 56217}}

If you just put that comma there right now, the diff
next time you add one will be one line less and more
readable.
Btw. you could also consider changing these to use
the
[ANAGLYPH_YB_DUBOIS] = {...}
syntax instead of putting that as a comment at the end.
Of course that should not be part of this patch but
a separate one.