[MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags.

[Ingo Brückl]

Benoît Thébaudeau wrote on Mon, 16 Jan 2012 21:09:13 +0100 (CET):

>> There probably should be two other checks.
>>
>> stream_tell(s)-len should not point before the beginning of the file, and
>> there should be an ID3 v4 tag with footer flag at this position.

> To be thorough, many other things could be checked:

Yes, I know. There can be very interesting things and combinations now with
all the different ID3 versions, but I think the two checks mentioned will
ensure that there is a (probably) valid header at a correct position, i.e.
that we really found a 3DI footer.

> If one of the checks that you propose fails, we know that there is a
> broken tag of unknown size present in the stream, so what should we do?

Don't consider it a (valid) tag and go on with the (wrong) size calculated so
far (as we would do with all other unknown tags).

Ingo