[MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags.

[Ingo Brückl]

Benoît Thébaudeau wrote on Mon, 16 Jan 2012 20:51:11 +0100 (CET):

> I'll do that if you prefer.

Actually, Reimar is the guy whose approval you'll need.

>> The version check should be 4.

> Or simply removed?

I would check it.

>> Indentation.

> What do you mean?

You used tabs. Please use spaces.

>> Hmm, A 3DI without flag could indicate that it isn't a 3DI footer at
>> all...

> Indeed, strictly speaking, but I considered that borderline ID3 generators
> could skip the header of appended tags like the footer of prepended tags
> can legally be, so it's more robust with this test. I can remove it if you
> prefer.

Without a proper header it could be happen to be data as well.

Ingo