[MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags.

[Benoît Thébaudeau]

Reimar,

> > > > +	demuxer->movi_end = stream_tell(s)-len;
> > > 
> > > And shouldn't this rather be FFMIN with the previous value?
> > > I am sure someone somewhere has managed to combine this with
> > > an ID3v1 tag in a way that overriding the value would result
> > > in trying to play back parts of the ID3v1 tag.
> > 
> > I don't see how there could be any issue here. It's exactly like
> > "demuxer->movi_end = stream_tell(s)-3;" for ID3v1. At this point,
> > the stream position is exactly between the end of the ID3v2 tag
> > and either the end of stream or the beginning of the ID3v1 tag
> > (which can be only after the ID3v2 tag).
> 
> Exactly that was my point. If previous behaviour is any indication
> there is already some tool out there that munges things together
> so that the ID3v1 tag ends up before.
> However I just looked at the code again and in that case your code
> just wouldn't find the ID3v2 tag, which is fine (of course only
> for the case that the ID3v2 tag was written inside the v1 tag,
> if it was just appended we won't detect the v1 tag. That seems
> like a slightly more likely thing but trying to handle it is
> probably not worth the effort).

OK. Please find attached a new version of the patch merging everyone's
comments.

Benoît
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1-demux-audio-skip-id3v2.4.patch
Type: text/x-patch
Size: 3143 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120116/542a5fae/attachment.bin>