[MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags.

Benoît Thébaudeau benoit.thebaudeau at advansee.com
Mon Jan 16 20:59:52 CET 2012


Reimar,

> > +	demuxer->movi_end = stream_tell(s)-len;
> 
> And shouldn't this rather be FFMIN with the previous value?
> I am sure someone somewhere has managed to combine this with
> an ID3v1 tag in a way that overriding the value would result
> in trying to play back parts of the ID3v1 tag.

I don't see how there could be any issue here. It's exactly like
"demuxer->movi_end = stream_tell(s)-3;" for ID3v1. At this point,
the stream position is exactly between the end of the ID3v2 tag
and either the end of stream or the beginning of the ID3v1 tag
(which can be only after the ID3v2 tag).

Benoît



More information about the MPlayer-dev-eng mailing list