[MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags.

[Reimar Döffinger]

On Mon, Jan 16, 2012 at 07:40:44PM +0100, Ingo Brückl wrote:
> > @@ -446,6 +448,17 @@ static int demux_audio_open(demuxer_t* d
> >  	g = stream_read_char(s);
> >  	demux_info_add(demuxer,"Genre",genres[g]);
> >        }
> > +      stream_seek(s,demuxer->movi_end-10);
> > +      stream_read(s,tag,4);
> > +      if( tag[0] == '3' && tag[1] == 'D' && tag[2] == 'I' && ((uint8_t)tag[3] >= 2)) {
> 
> One pair of () is pointless and I personally would prefer an unsigned char
> cast, but I don't know what Reimar thinks (he probably would go with hdr).

I don't see any point to use "unsigned char" ever, at best it
is a needlessly verbose way to do the same as uint8_t.