[MPlayer-dev-eng] Should #include <X11/extensions/XShm.h> be conditional?

[Wolfgang Draxinger]

On Wed, 04 Jan 2012 00:15:13 +0100
Ingo Brückl <ib at wupperonline.de> wrote:

> While currently checking the #ifdefs in the GUI code and whether they
> are necessary, I came across #include <X11/extensions/XShm.h>. As an
> extension, it doesn't necessarily have to be present, does it?
> 
> As far as I can see, there is no check or CONFIG definition for XShm
> in the configure script.
> 
> Should there be a condition for this include (and the function calls)?

IMHO no. Although it's entitled a "extension", XShm can be considered
"core" these days, just like XFixes or XInput. And you probably don't
want to run mplayer on a system that doesn't support them. I think it's
a safe assumption to consider XShm and XInput present if X11 is
detected.


Wolfgang