[MPlayer-dev-eng] [PATCH] update ad_mpg123 in preparation to replace mp3lib

Thomas Orgis thomas-forum at orgis.org
Wed Feb 29 18:35:22 CET 2012


Am Wed, 29 Feb 2012 16:37:48 +0100
schrieb Diego Biurrun <diego at biurrun.de>: 

> Good work, I'm glad to see all that ugly ifdeffery go. 

We could also remove the define for AD_MPG123_MEAN_BITRATE once we
settle for or against it. Looking at the wild estimates on track length
without that code, I'd rather opt for keeping the functionality. Though:
I do wonder if it could move to a more generic place, how do you get the
length (estimate) of an AAC stream dump? Counting how many bytes went
in and how much time worth of data came out so far is not MPEG1/2
specific.

> What's the
> minimum library version you are requiring now?

1.2.0, for safety with damaged streams (the MPG123_RESYNC_LIMIT
setting). I added a check for that to configure, see updated patch
(also with the formatting stuff).


Alrighty then,

Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-ready-to-obsolete-mp3lib.v2.patch
Type: text/x-patch
Size: 14646 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120229/80e47dc1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120229/80e47dc1/attachment-0001.asc>


More information about the MPlayer-dev-eng mailing list