[MPlayer-dev-eng] [PATCH] Fix compiling with osdep setenv

[Alexander Strasser]

Ivan Kalvachev wrote:
> On 2/16/12, Alexander Strasser <eclipse7 at gmx.net> wrote:
> >   on #mplayer IRC channel redxii reported the problem that
> > when compiling on MinGW.
> >
> >   The patch is not yet really tested and therefore might contain
> > stupid errors. Would be nice if someone could help out. I try to
> > test it more thoroughly but I am not sure when I will get around
> > to it.
> >
> >   Anyway I think the idea of the patch is easily understandable.
> > IIRC back in the day we did not add a prototype for osdep setenv
> > implementation because it was argued that it matches the default
> > C function signature (return int and take any arguments).
> >
> >   But nowadays we have -Werror-implicit-function-declaration in
> > CFLAGS and therefore the osdep setenv replacement will be build
> > on platforms missing it but the compilation will fail when
> > attempting to compile the C files that use it and therefore
> > never reach linking stage.
> 
> I think it is time to commit that.

  Yeah, as the build is reportedly broken with e.g. SDL features
auto-enabled.

  I will commit later tonight.

  Alexander