[MPlayer-dev-eng] run command patch

[Reimar Döffinger]

On Tue, Feb 14, 2012 at 10:10:56AM -0500, compn wrote:
> On Tue, 14 Feb 2012 12:32:32 +0100, Diego Biurrun wrote:
> >On Sun, Feb 12, 2012 at 09:16:18PM +0100, Jan Christoph Uhde wrote:
> >> --- DOCS/tech/slave.txt	(revision 34705)
> >> +++ DOCS/tech/slave.txt	(working copy)
> >> @@ -508,11 +508,16 @@
> >>  
> >> -run <value>
> >> -    Run <value> as shell command. In OSD menu console mode stdout and stdin
> >> +run <string>
> >> +    Run <string> as shell command. Properties are expanded before the string
> >> +    is passed as argument to sh. In OSD menu console mode stdout and stdin
> >>      are through the video output driver.
> >>  
> >> +    Example:
> >> +    run "echo '${filename} ${stream_pos}' >> ~/interesting position"
> >> +    Most shells would not be able to do this Parameter Expansion.
> >
> >Your remark about shells mystifies me.
> 
> 'this works only on bash, tcsh, etc'

It should work with any shell that supports "echo" and ">>",
I think that includes even Windows cmd.exe, so yes, I
am too a bit mystified by that.
On the code side the patch seems simple and nice to me,
though I didn't check too carefully for hidden issues.
If you agree on the documentation I think this is good to go.