[MPlayer-dev-eng] [PATCH] lavcac3enc: make the filter buildable with shared FFmpeg

Ivan Kalvachev ikalvachev at gmail.com
Mon Feb 13 00:48:39 CET 2012


On 2/6/12, Diego Biurrun <diego at biurrun.de> wrote:
> From: Anssi Hannula <anssi.hannula at iki.fi>
>
> Add some local definitions and a bitrate array to make FFmpeg private
> headers
> and symbols unneeded, allowing lavcac3enc to be built with shared FFmpeg.
>
> This also fixes the issue that the filter code expects the FFmpeg private
> definition AC3_MAX_CHANNELS to be the maximum number of "logical" channels
> to
> be encoded into AC-3, while it actually specifies the maximum channel count
> in
> the bitstream, which may include a coupling channel which is not an actual
> full
> audio channel. The issue is fixed by making the local AC3_MAX_CHANNELS have
> the
> value 6, which the FFmpeg private header also had before the addition of
> coupling support in 2011.

Now, since you have made it pointless for the author to send a new
patch with the requested changes, I think you should go ahead and
commit it.


More information about the MPlayer-dev-eng mailing list