[MPlayer-dev-eng] [PATCH]Do not use "64" to describe non 64bit image formats

[Reimar Döffinger]

On Mon, Feb 06, 2012 at 04:21:55AM +0100, Carl Eugen Hoyos wrote:
> Attached patch would allow simple 64 bit RGB support in a follow-up patch, but 
> I did not succeed testing the relevant code path in vo x11 and I don't know if 
> other parts in MPlayer relied on "64" for non-native image formats.

I don't think so, if so they are already broken just like X11.

> -    if (out_format & 64 && (IMGFMT_IS_RGB(out_format) || IMGFMT_IS_BGR(out_format))) {
> -      out_format &= ~64;
> +    if (out_format & 128 && (IMGFMT_IS_RGB(out_format) || IMGFMT_IS_BGR(out_format))) {

That must be
if (out_format == (IMGFMT_BGR32 | 128) || out_fmt == (IMGFMT_RGB32 | 128))
it doesn't work for any of the RGB/BGR formats that are not 4 bytes.
Well, it could be extended for the RGB64/BGR64 formats, but I don't
think those are supported by an X11 server anyway.
Note that to test this you need to run remote X to an X server of different
endianness.