[MPlayer-dev-eng] [PATCH] build: fix lavfi dependencies (swscale and swresample).

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 7 19:12:54 CET 2012


On Tue, Feb 07, 2012 at 05:36:41PM +0000, Carl Eugen Hoyos wrote:
> Reinhard Tartler <siretart <at> gmail.com> writes:
> 
> > I see. Well, adding the #include "avutil/mathematics.h" is anyway the
> > right thing to do, imo. You should always include headers that you
> > require and don't rely on headers that do that indirectly in general
> > no?
> 
> For the future, I would strongly suggest you do not commit patches 
> that add such useless code cluttering without proper review.

While I slightly disagree with the Libav policy, I very much think that
minimal compile fixes should be ok to commit directly, even
when they are "only" to fix Libav.
And I'd rather see Reinhard use his commit account more than
discourage him with flaming - at least so far.

Reimar


More information about the MPlayer-dev-eng mailing list