[MPlayer-dev-eng] [PATCH] Use "-nocache" option in TOOLS/midentify.sh

[compn]

On Tue, 7 Feb 2012 10:47:01 -0300, Rodrigo Campos wrote:
>On Tue, Jan 31, 2012 at 04:55:15PM -0300, Rodrigo Campos wrote:
>> Hi,
>> 
>> Attached there is a simple patch that adds the "-nocache" option to the script
>> midentify.sh in TOOLS/.
>> 
>> There are long delays with some hosts and using the cache only makes it take
>> longer, when we don't really need the cache. For example, from my ISP at
>> Argentina, using this option reduce *a lot* the time needed to run the script
>> with certain hosts:
>> 
>> (before the patch)
>> 
>> $ time TOOLS/midentify.sh http://58.69.143.152:8080
>> ID_AUDIO_ID=0
>> ID_FILENAME=http://58.69.143.152:8080
>> ID_DEMUXER=audio
>> ID_AUDIO_FORMAT=85
>> ID_AUDIO_BITRATE=40000
>> ID_AUDIO_RATE=22050
>> ID_AUDIO_NCH=0
>> ID_START_TIME=0.00
>> ID_LENGTH=-0.00
>> ID_SEEKABLE=0
>> ID_CHAPTERS=0
>> ID_AUDIO_BITRATE=40000
>> ID_AUDIO_RATE=22050
>> ID_AUDIO_NCH=2
>> ID_AUDIO_CODEC=mp3
>> ID_EXIT=EOF
>> 
>> real	0m33.409s
>> user	0m0.068s
>> sys	0m0.032s
>> 
>> 
>> (after the patch)
>> 
>> $ time TOOLS/midentify.sh http://58.69.143.152:8080
>> ID_AUDIO_ID=0
>> ID_FILENAME=http://58.69.143.152:8080
>> ID_DEMUXER=audio
>> ID_AUDIO_FORMAT=85
>> ID_AUDIO_BITRATE=40000
>> ID_AUDIO_RATE=22050
>> ID_AUDIO_NCH=0
>> ID_START_TIME=0.00
>> ID_LENGTH=-0.00
>> ID_SEEKABLE=0
>> ID_CHAPTERS=0
>> ID_AUDIO_BITRATE=40000
>> ID_AUDIO_RATE=22050
>> ID_AUDIO_NCH=2
>> ID_AUDIO_CODEC=mp3
>> ID_EXIT=EOF
>> 
>> real	0m5.340s
>> user	0m0.052s
>> sys	0m0.044s
>> 
>> 
>> The time also improves for some local streams (as expected, I think :))
>> 
>> 
>> Attached (inline) it is the path against r34643 (HEAD when  writing this email)
>> taken from the project root. If there is anything I should change in the patch,
>> or you want me to try something else, please let me know :)
>
>Ping ? :)
>
>It's been a week since the orig submit with no reason to reject it yet, and the
>patch is *really* simple (adding "-nocache" option to TOOLS/midentify.sh :))

patch looks ok to me. might want to put something in the changelog like
'added -nocache to midentify script, speeds up network stream
identification'

i'll apply in a few days if there are no other comments...

-compn