[MPlayer-dev-eng] [PATCH] GUI: Keep changed fullscreen mode during session

[Hans-Dieter Kosch]

Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Sun, 16 Dec 2012 01:08:25 +0100:
> 
>> currently, the fullscreen mode is reset to the startup mode
>> (gtkLoadFullscreen) upon playing a new stream.
> 
> This works as intended. It has been carefully designed to behave exactly like
> MPlayer itself.
> 
I'm sure, the current behaviour is not sloppy designed. It is as you said: What 
is right for one may be wrong for another. So, this patch is a proposal to 
discuss about. Would it be bad, if the GUI amends the "raw" MPlayer?

What would someone expect? Many things could be made configurable. But, the more 
options, the more complicated, and the more could be set wrong; and then there 
are bug reports, which are just incorrect settings.

Maybe my "problem" is, that I always compare a "software" player with a 
"hardware" DVD/CD player and expect similar behaviour...

>> E.g. if mplayer starts in window mode, then play a DVD/VCD or playlist,
>> switch to fullscreen, we are back in window mode with the next
>> chapter/track/file (and vice versa). This appears irritating and disturbs
>> continuous watching.
> 
> I agree with you that this should not happen with DVD playback and chapter
> changing (which is an issue to be fixed), but not generally.
> 
But what, if a user wants to watch a playlist like a disk? With each next file 
the mode would be reset.

My idea was that 'gtkLoadFullscreen' only defines the desired startup mode, and 
if the user decides to change the mode during session, he can stay with it for 
this session.

>> This applies also to the MPlayer image upon STOP.
> 
> What do you mean? Do you mean that it stays in fullscreen mode?
> 
No, not that. Currently, if MPlayer starts fullscreen, then the user switches to 
window mode (maybe he wants to do other things in parallel), after end of 
playback the MPlayer image suddenly pops up fullscreen; with the patch it 
doesn't change mode.

> On normal end of playback, by the way, there's another bug. The size stays in
> last video size.
> 
(I noticed that, too)


Hans-Dieter