[MPlayer-dev-eng] [PATCH] af_volnorm: make it work with float audio data

Giorgio Vazzana mywing81 at gmail.com
Sun Dec 16 10:46:46 CET 2012


2012/12/15 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> On 15 Dec 2012, at 15:04, Giorgio Vazzana <mywing81 at gmail.com> wrote:
>> The attached patch fixes this, assuming float samples are in the range
>> [-1.0f, 1.0f] (is there any codec that uses a different range?)
>> I have used it locally for about a month now, so I thought I'd send it upstream.
>
> Thanks, I think the multiplication with 1.0 is just confusing, I'd just remove it completely.
> Otherwise it seems right.

Ok, new patch attached.

>> * method*_int16 could use a lrintf() in the scale loop
>
> Hm, I forgot if it's really lrintf, but some of those float -> int conversion functions are awfully slow in some cases.

It's up to you, I saw it was already used in af_format::float2int().

Giorgio Vazzana
-------------- next part --------------
A non-text attachment was scrubbed...
Name: af_volnorm_float_1.patch
Type: application/octet-stream
Size: 1091 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20121216/80b27a7c/attachment.obj>


More information about the MPlayer-dev-eng mailing list