[MPlayer-dev-eng] [PATCH] GUI: Enhancement to r35555

[Hans-Dieter Kosch]

Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Sun, 09 Dec 2012 21:48:24 +0100:
> 
>> Ingo Brückl wrote:
>>> Hans-Dieter Kosch wrote on Sat, 08 Dec 2012 23:31:27 +0100:
>>>
>>>> If the current file is still present in the list, playback continues with
>>>> adjusted position.
>>> I've considered this in r35555, but we don't know anything about the files
>>> before the present one. These might have changed, too, so it's best to
>>> restart playback, because I don't think it's worth to check the list of file
>>> before it. (The reason for r35555 was to allow adding to the playlist while
>>> playing, not to change it at this stage.)
>>>
>> This was also my concern at first. However, since the playlist is
>> completely recreated upon selecting 'OK', we are always in sync, and it
>> works flawlessly. You can edit anything in the list, no issue will arise.
>> Or did I miss something?
> 
> No, there is no problem with the list or on-the-fly editing.
> 
> It's just that we don't know what the user meant with the editing if the
> position has changed (inserting an item, or delete one and/or exchanging some
> before the current one). To avoid extensive analysis that probably won't help
> us anyway, we simply restart. It's not worth the effort.
> 
Yes, the user is always the unknown being to us programmers ;-)

But I don't see any problem. I think it's just intuitive and logical; a user 
should be smart enough (and it's only those two lines of code).

The behaviour would be exactly the same like editing the program list of a TV 
receiver: The current program continues playing with adjusted program number.

And we could do even more: If the item at the current track number has changed, 
restart playing of this track number with the new item, just like TV receivers 
do; only go back to track 1 if current track number does no longer exist (i.e. 
we're beyond end of list; if track 1 does not exist, list is empty, but this 
case is handled anyway). Such a change should take only few lines of code.

Hans-Dieter