[MPlayer-dev-eng] [PATCH] Add option to set heartbeat command execution interval

[Reimar Döffinger]

On 5 Dec 2012, at 10:02, Android Jack <jackdroido at gmail.com> wrote:

> Hi !
> 
> Attached is a patch which adds a command line option named
> "-heartbeat-interval", which takes an integer >= 1 representing the
> delay in seconds between each execution of the command specified with
> the (existing) "-heartbeat-cmd" option, avoiding to hardcode this to
> 30 seconds.
> 
> I used "-heartbeat-cmd" option to implement a very simple keepalive
> functionality in my application which, in my case, kills mplayer in
> case of absence of an RTP stream. Being able to specify command
> execution interval, makes it much more responsive to RTP stream
> interruption.
> 
> I find it simple (at least, so it seems to me ;-)) to add to mplayer,
> and think it could be useful to someone else, so here it is.
> 
> This is my first submission to a BIG project, and have tried to comply
> with submitting rules ... so be understanding with me :-)

Thanks, it is fine.
But I think it would be better to make the type float, and also allow a value of 0.
I admit it seems unlikely to be useful, but I see no reason not to allow people to have the command run each time we loop through this code.
Could you make and test that change?

Thanks,
Reimar