[MPlayer-dev-eng] [PATCH] GUI: Corrections for showing video image size

Hans-Dieter Kosch hdkosch at kabelbw.de
Sun Dec 2 23:44:58 CET 2012


Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Sun, 02 Dec 2012 00:14:07 +0100:
> 
>> Then we could have a consistent behaviour: only show info about that, what
>> is currently really "playing", not what has been or will be, except the
>> filename of course; in case of the MPlayer image, it is its size, nothing
>> else. [...]
>> I think, it makes no sense to keep and show info about a file/stream/etc.
>> after playing which is then only partially available.
> 
> I think it makes no sense to not give available information only because we
> don't have all before playback. (With the image, it would be even "false"
> information.)
> 
Different points of view, but I feel OK with it, if it's consistent; and it's 
more and more :-)

However, an issue still remains in this context: In interface.c, lines 819-820:

guiInfo.VideoWidth  = guiApp.video.width;
guiInfo.VideoHeight = guiApp.video.height;

Here, the video size shown is overwritten by the MPlayer image size after end of 
file. I suppose, these lines should be removed now?

Hans-Dieter


More information about the MPlayer-dev-eng mailing list