[MPlayer-dev-eng] [PATCH] GUI: Corrections for showing video image size
Hans-Dieter Kosch
hdkosch at kabelbw.de
Sat Dec 1 21:21:40 CET 2012
Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Sat, 01 Dec 2012 02:43:08 +0100:
>
>> On startup, show the size of the MPlayer Idle Image (instead of the initial
>> 0x0, its size is also shown after end of file), if video window not hidden.
>
> I don't agree on that.
>
> The video width and height information is an information associated with a
> video file, and it is fixed (like the codec of the video). It's not the size
> of the video window.
Yes, what is shown is in deed not the actual size of the video window, but the
original video size independent of any zooming, also when displaying the MPlayer
image. I do not intend to show the window size.
> At the end of playback, this information remains (as filename, track number
> etc. already do) if playback is possible again. It must be reset if and only
> if no media is opened after playback (i.e. playlist is empty).
Then probably the GUI_END_FILE code has to be changed in interface.c, lines 815-816
guiInfo.VideoWidth = guiApp.video.width;
guiInfo.VideoHeight = guiApp.video.height;
which resets the indication to the MPlayer image size regardless of possible
again playback.
However, there would still be an inconsistency: At startup with a stored
playlist, the first filename is shown and playback is possible, but the size
information of this file is not yet available, while after playing it is; same
applies e.g. to guiInfo.RunningTime.
My idea is to consistently show information about the current visible state, and
the displayed filename shows what is currently playing or ready to play next.
This should finally cooperate harmonically with solving track number issues,
etc. This separated patch can't reflect the whole aspect.
Hans-Dieter
More information about the MPlayer-dev-eng
mailing list