[MPlayer-dev-eng] [PATCH] vf_ass: support uyvy and yuy2 directly

[Xidorn Quan]

On Thu, Aug 30, 2012 at 12:42 AM, Reimar Döffinger <Reimar.Doeffinger at gmx.de
> wrote:

> On Wed, Aug 29, 2012 at 10:37:55PM +0800, Xidorn Quan wrote:
> > Is there any problem still prevents this patch from being applied?
>
> My lack of time.
> But actually I was just about to commit it, but:
> > for (y = 0; y < y2 - y1; ++y)
> >     for (x = 0; x < mpi->w; ++x)
> >        AV_COPY32(dst + 4 * x, packed_color);
>
> This seems wrong to me, shouldn't it be mpi->w/2 ?
> I made that change locally (so I don't need you to send a new patch),
> but I want someone to confirm that it isn't just me thinking wrongly.
>

Well, I think you are right.

I found another problem here that vf_ass never check ass_use_margins
before using ass_top_margin and ass_bottom_margin. Even if I set
-noass-use-margins explicitly, it still applies margins.

However, it isn't the problem of this patch.