[MPlayer-dev-eng] Reverted patch of time-based PTS locking

Pásztor Szilárd don at tricon.hu
Sat Aug 25 15:16:12 CEST 2012


Pásztor Szilárd:
>  Reimar Döffinger:
> > Right, there's even a comment about that.
> > But what about leaving the !mpi and only moving drop_frame?
> > It's still not quite right I believe (at least for hard frame drop),
> > the thing we'd really need to know is "would we get a frame if we had
> > not set drop_frame".
> > There is also the issue that we'd really want to fetch the PTS value
> > in case of a decode error.
> > So I believe that would make the "right" solution to make the change
> > you tested, but also have a if (!got_frame) where we had a if (!mpi
> > ...).
> > Though I might be missing even more things.
> 
> Well, I don't know of any problems with the current (that is, patched)
> state and I'm not fond of changing things that aren't necessarily
> broken. Maybe a safety approach could be to leave the other parts
> intact unless something buggy comes up?

ping
:)
                     -------------------------------------
                     |  A closed mouth gathers no foot.  |
                     -------------------------------------


More information about the MPlayer-dev-eng mailing list