[MPlayer-dev-eng] [PATCH] vda support for mplayer

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Aug 18 11:57:26 CEST 2012


On Sat, Aug 18, 2012 at 11:48:31AM +0200, Reimar Döffinger wrote:
> > To make these code in FFmpeg, we need to
> > implement another decoder in FFmpeg, and that might cause another
> > addition data copying.
> 
> Since you already get the data in proper yuv format in system memory
> I can't see why it would ever cause an additional copy.
> (Note: you would _not_ support DR1 in that FFmpeg code, no user provided
> buffers but only direct export of the VDA buffers).

Look at libavcodec/libvpxdec.c and how it does it.
It passes out an internal buffer directly, and does not use get_buffer/
release_buffer.
If done that way, do you still believe that moving most of that code
into FFmpeg would cause any performance loss?
I'm really sorry for pushing you around between solutions, it's just that it
would be so much nicer because I believe it would
1) Make it easily possible to use VDA in FFmpeg itself as well
2) Avoid the special VDA pixfmt handling in MPlayer
3) Save us from maintaining any VDA code


More information about the MPlayer-dev-eng mailing list