[MPlayer-dev-eng] [PATCH] vda support for mplayer

[Zongyao Qu]

Just some technical suggestion.

> Attachment (h264_vda_mplayer_new.patch): application/octet-stream, 13 KiB
> 

+#define IMGFMT_UNWRAP_VDA(fmt) \
+    { if (IMGFMT_IS_VDA(fmt)) (fmt) = IMGFMT_YUY2; }

This is not a good use of macro, since we can't make sure fmt is a l-value.

+static uint32_t get_image(mp_image_t *mpi)
+{
+	if (!IMGFMT_IS_VDA(image_format))
+		return VO_NOTIMPL;
+
+	mpi->flags |= MP_IMGFLAG_DIRECT;
+	mpi->stride[0] = 0;
+	mpi->stride[1] = 0;
+	mpi->stride[2] = 0;
+	mpi->stride[3] = 0;
+	mpi->planes[0] = 1;
+	mpi->planes[1] = 0;
+	mpi->planes[2] = 0;
+	mpi->planes[3] = 0;
+	return VO_TRUE;
+}
+

It seams kinds of DR support in vo:corevideo, I suggest divide the patch to
 DR support and 
vda support separately.


I guess it would be broken if there is any non-dr filter in the filter chain.