[MPlayer-dev-eng] [PATCH] av_sub: support multiple rectangles.

[Reimar Döffinger]

On Sun, Apr 22, 2012 at 07:51:03PM +0200, Nicolas George wrote:
> -  if (packet->data_len) { // size 0 is a special "clear" packet
> +  if (packet->data_len) {

What I meant to say is that I think it would be good to have
the size 0 case commented here, too, not just at the other place.
Because otherwise one might wonder why you wouldn't just return NULL
in that case.

> +void spudec_packet_clear(packet_t *packet)
> +{
> +  memset(packet->packet, 0, packet->data_len);

Maybe add a comment that clearing alpha is not enough
because we need the brightness value to always be <= alpha?
Just because I myself had forgotten that again.
IMO you don't need to send another patch, just commit.