[MPlayer-dev-eng] [patch] fix SPDIF output on Mac

Hermi Mercury hermi.hg at gmail.com
Wed Sep 28 18:36:10 CEST 2011


2011/9/28 Diego Biurrun <diego at biurrun.de>

> On Mon, Sep 12, 2011 at 11:45:56PM +0200, Diego Biurrun wrote:
> > On Mon, Aug 22, 2011 at 03:49:47AM +0000, Zongyao Qu wrote:
> > >
> > > Recently, I made a fix for Mac users on Mac OS X 10.7.
> > >
> > > I didn't test it myself,
> > > but my users told me that this fixed the SPDIF output problem.
> > >
> > > I think I should share it, so other Mac mplayer users will be
> > > happy with it.
> > >
> > > I was told the line width is limited to 80 chars.
> > > so please refer to the link below to review the patch.
> > >
> > > https://www.gitorious.org/mplayer-for-mplayerx/
> > > mplayer/commit/b41d5d28fe2b2087e94e2facd035efb79dc0e93b
> >
> > Please eliminate the tabs and just send your patch here.
> > git-send-email will do, as will attaching the patch to an email.
> >
> > I was told at videolan dev days that this indeed fix problems
> > for some people, so the patch is desirable.  Would be great if
> > somebody could test it.  Do you know if it keeps older systems
> > in working order?
>
> I have attached the (whitespace-cleaned-up) patch here for reference.
> If somebody with a Mac could test or at least compile it, that would
> be much appreciated.  Otherwise I think I will apply it blind in a
> few days...
>

I have tested this patch (applied to an mplayer2 branch), and it does indeed
work properly for both AC3 and DTS audio under OS X 10.7.1 and 10.6.7.
 Though there is a crash bug present when muting the S/PDIF stream.  I have
proposed a fix for the crash here: http://devel.mplayer2.org/ticket/112

- Hermi


More information about the MPlayer-dev-eng mailing list