[MPlayer-dev-eng] [PATCH] remove mp3lib

xi ctrl.alt.sup at free.fr
Fri Sep 23 02:13:27 CEST 2011


Reimar Döffinger a écrit :
> On Thu, Sep 22, 2011 at 02:34:21AM +0200, xi wrote:
>> Erik Auerswald a écrit :
>>> Hi Xavier,
>>>
>>> On Wed, Sep 21, 2011 at 11:35:31AM +0200, xi wrote:
>>>> Dan Oscarsson wrote:
>>>>> ons 2011-09-21 klockan 00:18 +0000 skrev Carl Eugen Hoyos:
>>>>>> Reimar Döffinger<Reimar.Doeffinger<at>    gmx.de>    writes:
>>>>>>
>>>>>>> I am still interested in seeing performance numbers and statistics from
>>>>>>> ffmp3 vs. mp3lib when ffmp3 is slower,
>>>>>> When I tested (after FFmpeg optimisations were committed), ffmp2float was faster
>>>>>> on systems where it does not matter (including 64bit C, SSE2 and Altivec), but
>>>>>> slower than internal libmp3 on systems where I believe it does make a
>>>>>> difference, namely 32bit MMX and SSE.
>>>>>
>>>>> Does it make a difference that is significant?
>>>>> I have used mplayer on a 32bit system for many years together with
>>>>> vdpau. As vdpau does take nearly no CPU time, there was always lots of
>>>>> CPU available for audio decoding. It may be different if you do not have
>>>>> hardware video decoding, but sometime we have to decide if the work to
>>>>> support old hardware is worth the extra mess in the code.
>>>>> There are a lot of ancient drivers that would be nice to get rid of.
>>>>>
>>>>
>>>> Hey, please don't drop support for old hardware. MPlayer has always been
>>>> the best for playing the videos on my "old" hardware ; as a MPlayer
>>>> user, I wouldn't like this to change.
>>>
>>> Could you test the speed of mp3 decoding on your systems?
>>>
>>> Options to use:
>>>
>>> # for mp3lib
>>> -benchmark -vo null -ao null -afm mp3lib
>>>
>>> # for ffmp$WHATEVER
>>> -benchmark -vo null -vo null -afm ffmpeg
>>>
>>> You might need to additionally add -format s16le to force the same output
>>> format for a fair comparison.
>>>
>>
>> Ok, here are the results :
>
> I would welcome performance measurements from you, too
> (perf record/perf report for example).
> Carl will need a while longer before he can provide any.

Ok, I tried to use "perf" command, hope this is correct. eg :
"perf record -f mplayer -benchmark -vo null -ao null -afm mp3lib -format 
s16le /tmp/E-Type_Made_in_Sweden.mp3"
Then
"perf report > /tmp/test.txt"

Note that "perf" seems to be a recent kernel tool that was not included 
in the 2.6.22 kernel used for my PIII 850. So, the tests below are 
_only_ for my Dual athlon MP2800+.

If you need these tests on the PIII, let me know, I will boot a disk 
with a more recent kernel on it.


*** perf report for mp3lib :
     16.96%  mplayer  mplayer                               [.] 
0x0000000024e574
     12.11%  mplayer                              b71184c1  [.] 
0x000000b71184c1
      6.46%  mplayer  mplayer                               [.] 
synth_1to1_MMX
      5.84%  mplayer  mplayer                               [.] 
dct36_3dnowex
      4.06%  mplayer  [kernel]                              [k] acpi_pm_read
      4.06%  mplayer  mplayer                               [.] 
dct64_MMX_3dnowex
      3.87%  mplayer  [kernel]                              [k] __do_fault
      2.20%  mplayer  mplayer                               [.] 
0x000000000e8373
      1.95%  mplayer  mplayer                               [.] main
      1.71%  mplayer  libc-2.11.1.so                        [.] __GI_memcpy
      1.68%  mplayer  libc-2.11.1.so                        [.] ___printf_fp
      1.68%  mplayer  libc-2.11.1.so                        [.] 
__GI_vfprintf
      1.07%  mplayer  libc-2.11.1.so                        [.] __GI_strncpy
      0.95%  mplayer  libGL.so.280.13                       [.] 
0x0000000007e242
      0.92%  mplayer  mplayer                               [.] 
0x0000000014f260
      0.77%  mplayer  mplayer                               [.] 
MP3_DecodeFrame
      0.76%  mplayer  libc-2.11.1.so                        [.] __strchrnul
      0.76%  mplayer  ld-2.11.1.so                          [.] 
_dl_map_object_from_fd
      0.73%  mplayer  [kernel]                              [k] n_tty_write
      0.70%  mplayer  libnvidia-tls.so.280.13               [.] 
0x00000000001ad3
      0.70%  mplayer  [kernel]                              [k] 
tty_buffer_request_room
      0.68%  mplayer  libc-2.11.1.so                        [.] memset
      0.67%  mplayer  mplayer                               [.] fast_memcpy
      0.60%  mplayer  [kernel]                              [k] 
sysenter_past_esp
      0.56%  mplayer  [kernel]                              [k] schedule
      0.56%  mplayer  mplayer                               [.] 
0x00000000903035
      0.54%  mplayer  [kernel]                              [k] copy_to_user
      0.52%  mplayer  mplayer                               [.] 
mp_decode_audio
      0.51%  mplayer  [kernel]                              [k] 
get_page_from_freelist
      0.48%  mplayer  [kernel]                              [k] do_select
      0.48%  mplayer  [kernel]                              [k] sys_ioctl
      0.44%  mplayer  libc-2.11.1.so                        [.] __GI_strcmp
      0.43%  mplayer  [kernel]                              [k] tty_write
      0.43%  mplayer  [kernel]                              [k] 
find_busiest_group
      0.41%  mplayer  [kernel]                              [k] tty_ioctl
      0.41%  mplayer  libc-2.11.1.so                        [.] __GI_memmove
      0.38%  mplayer  mplayer                               [.] GetTimerMS
      0.38%  mplayer  [kernel]                              [k] 
__copy_to_user_ll


*** perf report for ffmp3float :
     27.69%  mplayer  mplayer                               [.] 
0x000000003b2890
     10.76%  mplayer  mplayer                               [.] 
ff_mpadsp_apply_window_float
      4.12%  mplayer  libc-2.11.1.so                        [.] 
__GI_vfprintf
      3.78%  mplayer  libc-2.11.1.so                        [.] ___printf_fp
      3.59%  mplayer  [kernel]                              [k] __do_fault
      3.43%  mplayer  [kernel]                              [k] acpi_pm_read
      2.30%  mplayer  libc-2.11.1.so                        [.] memset
      2.28%  mplayer  libc-2.11.1.so                        [.] __GI_strncpy
      1.73%  mplayer  libc-2.11.1.so                        [.] __GI_memcpy
      1.62%  mplayer  libc-2.11.1.so                        [.] __GI_memmove
      1.13%  mplayer  libnvidia-tls.so.280.13               [.] 
0x000000000017d0
      1.11%  mplayer  libGL.so.280.13                       [.] 
0x0000000007d951
      1.09%  mplayer  mplayer                               [.] main
      0.97%  mplayer  libc-2.11.1.so                        [.] _int_malloc
      0.95%  mplayer  [kernel]                              [k] n_tty_write
      0.79%  mplayer  mplayer                               [.] mp_msg_va
      0.71%  mplayer  [kernel]                              [k] 
get_page_from_freelist
      0.69%  mplayer  libc-2.11.1.so                        [.] _int_free
      0.56%  mplayer  mplayer                               [.] 
update_subtitles
      0.54%  mplayer  [nvidia]                              [k] _nv015253rm
      0.53%  mplayer  libc-2.11.1.so                        [.] 
_IO_default_xsputn_internal
      0.50%  mplayer  ld-2.11.1.so                          [.] 
_dl_relocate_object
      0.50%  mplayer  libc-2.11.1.so                        [.] __GI_select
      0.50%  mplayer  libc-2.11.1.so                        [.] 
__GI_gettimeofday
      0.50%  mplayer  libc-2.11.1.so                        [.] 
mem2chunk_check
      0.49%  mplayer  libc-2.11.1.so                        [.] _IO_fputs
      0.47%  mplayer  libc-2.11.1.so                        [.] 
__GI___libc_malloc
      0.44%  mplayer  libc-2.11.1.so                        [.] 
__gconv_transform_utf8_internal
      0.42%  mplayer  libc-2.11.1.so                        [.] 
__gconv_transform_internal_utf8
      0.41%  mplayer  [kernel]                              [k] 
tty_buffer_request_room
      0.39%  mplayer  [vdso]                                [.] 
0x000000ffffe415
      0.39%  mplayer  libc-2.11.1.so                        [.] __vsnprintf
      0.38%  mplayer  [kernel]                              [k] do_select
      0.37%  mplayer  libc-2.11.1.so                        [.] __strchrnul
      0.37%  mplayer  libc-2.11.1.so                        [.] 
hack_digit.12363
      0.35%  mplayer  mplayer                               [.] 
mp_decode_audio
      0.33%  mplayer  libc-2.11.1.so                        [.] malloc_check
      0.32%  mplayer  [kernel]                              [k] 
_copy_from_user
      0.29%  mplayer  libc-2.11.1.so                        [.] 
__mpn_extract_double
      0.28%  mplayer  [kernel]                              [k] tty_write
      0.28%  mplayer  [kernel]                              [k] 
__copy_to_user_ll


*** perf report for ffmp3 :
     41.18%  mplayer                               80c8b47  [.] 
0x000000080c8b47
     19.81%  mplayer  mplayer                               [.] 
ff_mpadsp_apply_window_fixed
      6.51%  mplayer  mplayer                               [.] 
0x00000000903081
      3.32%  mplayer  [kernel]                              [k] acpi_pm_read
      2.49%  mplayer  [kernel]                              [k] __do_fault
      1.72%  mplayer  mplayer                               [.] 
ff_dct32_fixed
      0.79%  mplayer  libc-2.11.1.so                        [.] 
__GI_vfprintf
      0.71%  mplayer  mplayer                               [.] 
0x000000000d8cc2
      0.68%  mplayer  [kernel]                              [k] n_tty_write
      0.58%  mplayer  libc-2.11.1.so                        [.] ___printf_fp
      0.54%  mplayer  libc-2.11.1.so                        [.] __GI_memcpy
      0.52%  mplayer  libc-2.11.1.so                        [.] __GI_strncpy
      0.50%  mplayer  [kernel]                              [k] 
__copy_to_user_ll
      0.45%  mplayer  [kernel]                              [k] 
get_page_from_freelist
      0.43%  mplayer  mplayer                               [.] main
      0.42%  mplayer  ld-2.11.1.so                          [.] 
_dl_relocate_object
      0.39%  mplayer  libc-2.11.1.so                        [.] 
__gconv_transform_utf8_internal
      0.37%  mplayer  [kernel]                              [k] 
_raw_spin_lock_irqsave
      0.37%  mplayer  libc-2.11.1.so                        [.] _int_malloc
      0.34%  mplayer  [kernel]                              [k] tty_ioctl
      0.34%  mplayer  libGL.so.280.13                       [.] 
0x0000000007e217
      0.33%  mplayer  [vdso]                                [.] 
0x000000ffffe414
      0.29%  mplayer  [kernel]                              [k] 
sysenter_past_esp
      0.28%  mplayer  mplayer                               [.] 
0x000000001f2002
      0.24%  mplayer  libc-2.11.1.so                        [.] memset
      0.23%  mplayer  libc-2.11.1.so                        [.] 
__GI_gettimeofday
      0.23%  mplayer  [kernel]                              [k] 
tty_buffer_request_room
      0.22%  mplayer  libc-2.11.1.so                        [.] __GI_memmove
      0.21%  mplayer  libc-2.11.1.so                        [.] _int_free
      0.21%  mplayer  [kernel]                              [k] 
_raw_spin_lock_irq
      0.21%  mplayer  libm-2.11.1.so                        [.] 
0x00000000007bc0
      0.20%  mplayer  [kernel]                              [k] do_select
      0.20%  mplayer  [kernel]                              [k] 
perf_adjust_period
      0.20%  mplayer  [kernel]                              [k] 
enqueue_hrtimer
      0.20%  mplayer  libc-2.11.1.so                        [.] __strchrnul
      0.20%  mplayer  [kernel]                              [k] copy_to_user


Note : reports are incomplete, I have removed the end because it was huge.

Xavier


More information about the MPlayer-dev-eng mailing list