[MPlayer-dev-eng] [PATCH] remove mp3lib

[xi]

Erik Auerswald a écrit :
> Hi Xavier,
>
> On Wed, Sep 21, 2011 at 11:35:31AM +0200, xi wrote:
>> Dan Oscarsson wrote:
>>> ons 2011-09-21 klockan 00:18 +0000 skrev Carl Eugen Hoyos:
>>>> Reimar Döffinger<Reimar.Doeffinger<at>   gmx.de>   writes:
>>>>
>>>>> I am still interested in seeing performance numbers and statistics from
>>>>> ffmp3 vs. mp3lib when ffmp3 is slower,
>>>> When I tested (after FFmpeg optimisations were committed), ffmp2float was faster
>>>> on systems where it does not matter (including 64bit C, SSE2 and Altivec), but
>>>> slower than internal libmp3 on systems where I believe it does make a
>>>> difference, namely 32bit MMX and SSE.
>>>
>>> Does it make a difference that is significant?
>>> I have used mplayer on a 32bit system for many years together with
>>> vdpau. As vdpau does take nearly no CPU time, there was always lots of
>>> CPU available for audio decoding. It may be different if you do not have
>>> hardware video decoding, but sometime we have to decide if the work to
>>> support old hardware is worth the extra mess in the code.
>>> There are a lot of ancient drivers that would be nice to get rid of.
>>>
>>
>> Hey, please don't drop support for old hardware. MPlayer has always been
>> the best for playing the videos on my "old" hardware ; as a MPlayer
>> user, I wouldn't like this to change.
>
> Could you test the speed of mp3 decoding on your systems?
>
> Options to use:
>
> # for mp3lib
> -benchmark -vo null -ao null -afm mp3lib
>
> # for ffmp$WHATEVER
> -benchmark -vo null -vo null -afm ffmpeg
>
> You might need to additionally add -format s16le to force the same output
> format for a fair comparison.
>

Ok, here are the results :

*** Pentium III 850MHz :

[xi at localhost mp3]$ /usr/local/bin/mplayer -benchmark -vo null -ao null 
-afm mp3lib -format s16le E-Type_Made_in_Sweden.mp3
MPlayer SVN-r34117-4.2.2 (C) 2000-2011 MPlayer Team

Playing E-Type_Made_in_Sweden.mp3.
Audio only file format detected.
==========================================================================
Trying to force audio codec driver family mp3lib...
Opening audio decoder: [mp3lib] MPEG layer-2, layer-3
AUDIO: 44100 Hz, 2 ch, s16le, 128.0 kbit/9.07% (ratio: 16000->176400)
Selected audio codec: [mp3] afm: mp3lib (mp3lib MPEG layer-2, layer-3)
==========================================================================
AO: [null] 44100Hz 2ch s16le (2 bytes per sample)
A:  94.8 (01:34.7) of 94.0 (01:34.0)  1.7%

BENCHMARKs: VC:   0.000s VO:   0.000s A:   1.622s Sys:  96.708s =   98.330s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  1.6494% Sys: 98.3506% = 100.0000%


[xi at localhost mp3]$ /usr/local/bin/mplayer -benchmark -vo null -ao null 
-afm ffmpeg -format s16le E-Type_Made_in_Sweden.mp3 :
BENCHMARKs: VC:   0.000s VO:   0.000s A:   2.057s Sys:  96.686s =   98.743s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  2.0837% Sys: 97.9163% = 100.0000%


[xi at localhost mp3]$ /usr/local/bin/mplayer -benchmark -vo null -ao null 
-afm ffmpeg -ac ffmp3 -format s16le E-Type_Made_in_Sweden.mp3 :
BENCHMARKs: VC:   0.000s VO:   0.000s A:   2.952s Sys:  94.833s =   97.786s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  3.0193% Sys: 96.9807% = 100.0000%




*** AMD Dual athlon MP2800+ :

mplayer -benchmark -vo null -ao null -afm mp3lib -format s16le 
/tmp/E-Type_Made_in_Sweden.mp3 :
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.773s Sys:  96.513s =   97.286s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  0.7944% Sys: 99.2056% = 100.0000%

mplayer -benchmark -vo null -ao null -afm ffmpeg -format s16le 
/tmp/E-Type_Made_in_Sweden.mp3 :
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.926s Sys:  96.484s =   97.410s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  0.9507% Sys: 99.0493% = 100.0000%

mplayer -benchmark -vo null -ao null -afm ffmpeg -ac ffmp3 -format s16le 
/tmp/E-Type_Made_in_Sweden.mp3 :
BENCHMARKs: VC:   0.000s VO:   0.000s A:   1.736s Sys:  96.480s =   98.216s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  1.7674% Sys: 98.2326% = 100.0000%


Hope this helps,
Xavier