[MPlayer-dev-eng] [PATCH] remove mp3lib

[Erik Auerswald]

Hi Xavier,

On Wed, Sep 21, 2011 at 11:35:31AM +0200, xi wrote:
> Dan Oscarsson wrote:
>> ons 2011-09-21 klockan 00:18 +0000 skrev Carl Eugen Hoyos:
>>> Reimar Döffinger<Reimar.Doeffinger<at>  gmx.de>  writes:
>>>
>>>> I am still interested in seeing performance numbers and statistics from
>>>> ffmp3 vs. mp3lib when ffmp3 is slower,
>>> When I tested (after FFmpeg optimisations were committed), ffmp2float was faster
>>> on systems where it does not matter (including 64bit C, SSE2 and Altivec), but
>>> slower than internal libmp3 on systems where I believe it does make a
>>> difference, namely 32bit MMX and SSE.
>>
>> Does it make a difference that is significant?
>> I have used mplayer on a 32bit system for many years together with
>> vdpau. As vdpau does take nearly no CPU time, there was always lots of
>> CPU available for audio decoding. It may be different if you do not have
>> hardware video decoding, but sometime we have to decide if the work to
>> support old hardware is worth the extra mess in the code.
>> There are a lot of ancient drivers that would be nice to get rid of.
>>
>
> Hey, please don't drop support for old hardware. MPlayer has always been  
> the best for playing the videos on my "old" hardware ; as a MPlayer  
> user, I wouldn't like this to change.

Could you test the speed of mp3 decoding on your systems?

Options to use:

# for mp3lib
-benchmark -vo null -ao null -afm mp3lib

# for ffmp$WHATEVER
-benchmark -vo null -vo null -afm ffmpeg

You might need to additionally add -format s16le to force the same output
format for a fair comparison.

I don't know if there is an "official" test sample and not even if mp3 or
mp2 format should be tested (Carl Eugen mentioned ffmp2float).

> Typically, thanks to mplayer, my main computer (Bi-amd MP2800+) is able  

For that one it should not matter (mp3 is usually not used for HD content).

> MPlayer also works out of the box for playing SD videos on my PIII 850,  
> using libmp3 and xmga video output driver for matrox card ...

That is a more interesting system to test.

Thanks,
Erik
-- 
Ringing telephones (and other symmetric communication lines) are the
bane of focused work.
                        -- René Pfeiffer