[MPlayer-dev-eng] [PATCH] Doxygen and conditional compilation

[Reimar Döffinger]

On Mon, Sep 19, 2011 at 11:10:51PM +0200, Ingo Brückl wrote:
> Diego Biurrun wrote on Mon, 19 Sep 2011 11:57:20 +0200:
> 
> > I must say this has a smell of workaround to it.
> 
> If it's OK to make conditional definitions (to remove otherwise useless
> code), I can't understand why everyone is saying this.

For _code_ yes, but not for _declarations in header files_.
The libvo X11 stuff was of the latter kind.

> > What problem are you trying to fix exactly?
> 
> See gui/interface.h line 105 or gui/ui/gtk/menu.c, line 383 or mplayer.c,
> line 542, for example. Shouldn't these show up in a (complete) MPlayer
> documentation (i.e. shouldn't all the CONFIGs be set for a complete
> documentation)?

Yes, for those that's probably the proper way.
Though in case of gui/interface.h most of those #ifdefs seems rather pointless
(saving only a few bytes in a configuration hopefully almost no-one
uses), or rather in light of e.g. Bluray probably incorrect.