[MPlayer-dev-eng] GUI and vo_x11 functions

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 12 Sep 2011 18:28:52 +0200:

> On Mon, Sep 12, 2011 at 04:13:55PM +0200, Ingo Brückl wrote:
>> need the various WinID < 0 conditions - in fact shouldn't have them.
>> vo_x11_ontop() and vo_x11_border() are only called via control/VOCTRL
>> which should be allowed.

> I disagree. A frontend does not necessarily have its own key handling
> but might instead just pass things on to MPlayer.
> It shouldn't have to risk that MPlayer completely messes up its window
> just because of that.

Sorry, but I don't get it.

If we block vo_x11_ontop() by a WinID < 0 condition a control() VOCTRL_ONTOP
call won't do anything. If we don't do that (and patch vo_x11_setlayer()) the
call will work as expected and I can't see any mess-up. (VOCTRL_BORDER is
already working the same way.)

Ingo