[MPlayer-dev-eng] GUI and vo_x11 functions

[Reimar Döffinger]

On Fri, Sep 09, 2011 at 05:09:24PM +0200, Ingo Brückl wrote:
> Index: libvo/x11_common.c
> ===================================================================
> --- libvo/x11_common.c	(revision 34097)
> +++ libvo/x11_common.c	(working copy)
> @@ -1206,7 +1206,7 @@
>  
>  void vo_x11_setlayer(Display * mDisplay, Window vo_window, int layer)
>  {
> -    if (WinID >= 0)
> +    if (!WinID)
>          return;
>  
>      if (vo_fs_type & vo_wm_LAYER)
> @@ -1431,7 +1431,7 @@
>  {
>      vo_ontop = (!(vo_ontop));
>  
> -    vo_x11_setlayer(mDisplay, vo_window, vo_ontop);
> +    if (WinID < 0) vo_x11_setlayer(mDisplay, vo_window, vo_ontop);
>  }

I very much dislike having half the WinID check in the function and the
other half outside.
I don't mind removing it completely, but IMO leaving the !WinID there is
confusing.
Even more so since it possibly should really check the vo_window
parameter instead of WinID.