[MPlayer-dev-eng] [RFC PATCH] Default to subtitle visibility off (was Re: Question for dev's: Does mplayer disable DPMS timeouts? "xset q" looks good, but timeouts never trigger)

[Erik Auerswald]

Hi,

On Wed, Sep 07, 2011 at 03:38:16PM +0200, Reimar Döffinger wrote:
> On 7 Sep 2011, at 12:47, Nicolas George <nicolas.george at normalesup.org> wrote:
> > Le primidi 21 fructidor, an CCXIX, Erik Auerswald a écrit :
> [...]
> >> No, it introduces a regression. This would not be the first such change of
> >> behaviour to the worse (-nosub is needed for DVDs now-a-days, which was
> >> not needed back-in-the-day).
> > 
> > People who need subtitles would think it is a change for the best.
> 
> It should be a similarly easy thing to change the default for that too.
> Never considered it relevant enough to bother though.
> Well, it might be a bit more involved, since I think it needs also
> a change to allow -sid -1 otherwise the current behaviour becomes
> completely unaccessible.

My goal is to see no subtitles unless explicitly specifying some. Having a
default subtitle language set should not count as specifying a subtitle. It
should just provide a useful default selection for switching on subtitle
visibility interactively.

I took a first look at the code and came up with the untested idea in the
attached patch. Since I currently have no DVDs handy I can't even test if
this does what I want it to. Comments welcome. :-)

Handle with care, the patch is completely untested and might drink all
your beer. ;-)

Thanks,
Erik
-- 
Once is happenstance. Twice is coincidence. Three times is enemy action.
                        -- Auric Goldfinger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-subtitle-visibility.RFC.patch
Type: text/x-diff
Size: 835 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110908/86b6e581/attachment.bin>