[MPlayer-dev-eng] [PATCH] GUI cursor control

[Ingo Brückl]

Alexander Strasser wrote on Sun, 4 Sep 2011 20:21:08 +0200:

> I looked at the code again, and now I think I know what you are after.

Maybe I shouldn't have said "full" cursor control. I was only looking for a
degree of control that eliminates the problems but retains the advantages.
(Let's call the change in vo_x11_uninit() solution #1.)

> Wouldn't it be better to have the X11 VOs not interfere with cursor
> management if an external WinID is used? In that case you would would be in
> control of it remaining invisible and responsible for making it visible.

You mean something like the attached patch and having a mouse_autohide code
in GUI's wm/ws.c? Yes, this would really give full cursor control to the
application owning the WinID and I'm perfectly fine with this (solution #2),
but I'm wondering whether this may affect other GUIs using MPlayer as backend
and depending on the current behavior.

>> > Maybe it is a more viable approach to disable them from inside the
>> > vo_showcursor/vo_hidecursor routines themselves and document them while at
>> > it.
>>
>> I don't want to do that because this would prevent the useful autohide
>> feature.

> I guess this is the reason you don't want to get into full control of the
> cursor visibility.

Yes.

> In case you want to keep this functionality, which depends on internal VO
> state, then I would expect it to be better to make it just work out without
> your interference. Maybe by doing the opposite change and letting the VO
> code make it invisible.

This would be solution #3, but letting the VO code make the cursor invisible
(and thus letting make it visible as well, i.e. leaving full control to the
VO code) has the disadvantage that the cursor will show up / flash shortly
between videos in a playlist which I dislike.

To summarize, I'm fine with #1 (small solution) and #2 (full control
solution), but not with #3.

Which one are you in favor of?

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x11_common.patch
Type: text/x-diff
Size: 848 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110905/6f91c5e5/attachment.bin>