[MPlayer-dev-eng] [PATCH] GUI cursor control

[Ingo Brückl]

Alexander Strasser wrote on Sun, 4 Sep 2011 17:02:25 +0200:

> I agree that this is a good idea and that hidecursor should be disabled
> too.

vo_hidecursor() never gets called in case of WinID >= 0. The "goto final"
prevents that. This leads to an annoying "cursor visible bug" in the GUI.
(While making the cursor invisible is no problem, the GUI currently has no
control of it remaining invisible.)

As there is no hidecursor for WinIDs, we all seem to agree that there
shouldn't be a showcursor either.

> Maybe it is a more viable approach to disable them from inside the
> vo_showcursor/vo_hidecursor routines themselves and document them while at
> it.

I don't want to do that because this would prevent the useful autohide
feature.

> Also I could not find any of these called outside the x11_common object
> module, so it may be a good idea to remove the prototypes and make them
> private to x11_common.c by marking them static.

Good point, so I revised the patch.

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_x11_uninit.3.patch
Type: text/x-diff
Size: 1317 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110904/d34f1a57/attachment.bin>