[MPlayer-dev-eng] MPlayer/MEncoder crash on using -vf scale and expand together. Fix attached.
ikalvachev at gmail.com
Fri Oct 28 18:53:40 CEST 2011
On 10/28/11, Alex C <alexc.xander at yahoo.in> wrote:
> Problem: SIGSEGV on mplayer -vf scale=720:480,expand=720:480 test.mkv
> Sample test file:
> Backtrace on: http://pastebin.com/uHPRtswz
> Similar to ffmpeg bug:
> Patched in ffmpeg by michaelni:
> I have applied a similar patch for mplayer. Patch is attached. The crash is
> averted as a result.
Your patch is reverted (aka the newer file is at ---).
I'm also keeping the MP_IMGFLAG_ACCEPT_STRIDE, it is needed for the xv
direct rendering. I'm also applying this to the second vf_get_image()
at line 379 in start_slice() function.
No need to resend the patch, I'll commit in a minutes.
I'll use this commit message.
Fix segfault in scale due to unaligned stride.
The MP_IMGFLAG_PREFER_ALIDNED_STRIDE is honored only
in MP_IMGTYPE_EXPORT, but vf_scale uses it only with MP_IMGTYPE_TEMP.
As result stride is not aligned and this causes misalignment for SSE code.
Use MP_IMGFLAG_ACCEPT_ALIDNED_STRIDE instead, that aligns it in all cases.
Solution and initial patch by alexc.xander.yahoo.in.
More information about the MPlayer-dev-eng