[MPlayer-dev-eng] [PATCH] demux_pva fixes

Alexander Strasser eclipse7 at gmx.net
Tue Oct 18 23:15:38 CEST 2011


Hi

Matteo Giani wrote:
> On Thu, Oct 13, 2011 at 11:41 PM, Matteo Giani <matteo.giani at gmail.com>wrote:
> 
> > I will resubmit as separate patches against current svn as per Dominik's
> > request as soon as I get the chance, hopefully over the weekend.
> >
> 
> As per my previous message, resubmitting the changes split into two patches:
> * a very small (2-line basically) patch fixing the two functional issues
> * the overall patch including the above plus the cleanup points

  Sorry, I don't comment on the changes themselves. Just a note on
the way this is submitted. It would have been better to not have
the first patch also included in the second patch. In other words:
you should assume some application order and make the patches so
they can be applied and committed incrementally. 

  In this specific case your first patch is extremely small, so it
might make sense to wait for comments first before taking action on
this submittal shortcoming.

[...]

  Alexander


More information about the MPlayer-dev-eng mailing list