[MPlayer-dev-eng] load_per_xxx_config() issue

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Oct 14 20:00:30 CEST 2011


On Fri, Sep 30, 2011 at 05:50:16PM +0200, Ingo Brückl wrote:
> I wrote on Thu, 29 Sep 2011 01:25:13 +0200:
> 
> > Is this considered to be ok or a bug?
> 
> >   $ mplayer test.mp3
> >   MPlayer SVN-r34149-4.3.4 (C) 2000-2011 MPlayer Team
> >   Loading extension-related profile 'extension.mp3'
> 
> >   Playing test.mp3.
> 
> > Extension-related profile is loaded.
> 
> >   $ mplayer -slave -idle
> >   MPlayer SVN-r34149-4.3.4 (C) 2000-2011 MPlayer Team
> >   load test.mp3
> 
> >   Playing test.mp3.
> 
> > Extension-related profile isn't loaded.
> 
> Well, if not ok, this patch could fix it.
> 
> Ingo

> Index: mplayer.c
> ===================================================================
> --- mplayer.c	(revision 34165)
> +++ mplayer.c	(working copy)
> @@ -990,6 +990,17 @@
>      }
>  }
>  
> +static int load_profile_config(m_config_t *conf, const char *const file)
> +{
> +    if (file) {
> +        load_per_protocol_config(conf, file);
> +        load_per_extension_config(conf, file);
> +        load_per_file_config(conf, file);
> +    }
> +
> +    return (file != NULL);

Probably a good idea, but no need for the ().


More information about the MPlayer-dev-eng mailing list