[MPlayer-dev-eng] [PATCH]SPDIF pass through decoder

[Naoya OYAMA]

Hi,
Thank you for review.
Patch update.

2011/10/10, Diego Biurrun <diego at biurrun.de>:
> On Mon, Oct 10, 2011 at 04:24:24PM +0900, Naoya OYAMA wrote:
>> Patch updated.
>>
>> --- libmpcodecs/ad_spdif.c	(revision 0)
>> +++ libmpcodecs/ad_spdif.c	(revision 0)
>> @@ -0,0 +1,310 @@
>> +static int read_packet(void *p, uint8_t *buf, int buf_size)
>> +{
>> +    //do nothing.
>> +    return 0;
>> +}
>> +
>> +static int64_t seek(void *p, int64_t offset, int whence)
>> +{
>> +    //do nothing.
>> +    return 0;
>> +}
>
> pointless comments
Modify comments.
"spdifenc does not use read/seek callback."

>> +    case CODEC_ID_DTS: // FORCE USE DTS-HD
>> +        opt = av_opt_find(&lavf_ctx->oformat->priv_class,
>> +                          "dtshd_rate", NULL, 0, 0);
>> +        if (!opt)
>> +            goto fail;
>> +        dtshd_rate                      = lavf_ctx->priv_data +
>> opt->offset;
>
> libmpcodecs/ad_spdif.c:182: warning: pointer of type 'void *' used in
> arithmetic
Fix it.

>> +    fail:
>> +    uninit(sh);
>> +    return 0;
>
> Please place the goto label in the first column.
Fix it.

Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer_spdif5.patch
Type: text/x-patch
Size: 19465 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111012/7c516f4d/attachment-0001.bin>