[MPlayer-dev-eng] [PATCH] Add idle option to Windows GUI preferences dialog

[Ingo Brückl]

Stephen Sheldon wrote on Sun, 02 Oct 2011 08:12:08 -0700:

> Here is the patch.

Thanks a lot. Applied with two minor changes.

I prefer ID_IDLE (after the option name) to ID_QUIT (after the text).

> I used the #define from help_mp.h, rather than the text itself. There are
> no other uses in the win32 gui, so on a non-English system it might look
> odd.

That's the reason why I chose the text itself.

> That is a future enhancement for the win32 gui.

Yes, it would be nice to replace all the text constants by their MSGTR
definitions.

> There are 2 problems with the existing defaults which I did not address:
> 1) On my Windows 7 with Aero system, directx is the wrong choice.

What would be more appropriate for a Windows system nowadays? Direct3D?

Anyone here who knows for sure?

> 2) "Display videos in the sub window" does not display any video.  I am
> not sure what this means,

That's a strange option. It's for DirectX anyway. (I'll add that to the text
for now.)

If I uncheck it, I get a behavior I'd call normal. Switching is possible
between fullscreen and a small video window with the desktop visible.

If I check it, only fullscreen mode is normal. The small video window either
isn't visible or the desktop background isn't.

Seems that sub_window = 0 is a more reasonable default. (And the text should
be changed to explain the benefit the user - if any.)

Ingo