[MPlayer-dev-eng] [PATCH] reorder pts when needed

[Reimar Döffinger]

On Mon, Nov 28, 2011 at 10:36:10AM +0100, Dan Oscarsson wrote:
> sön 2011-11-27 klockan 19:33 +0100 skrev Reimar Döffinger:
> > The point is not whether reordering is required to get the correct
> > PTS but why the code should be allowed to break when the PTS are
> > not correct.
> > But I don't seem to convince anyone so I guess I'll try to find time
> > to do it myself, probably trying to fix that code we removed instead
> > of just removing it.
> 
> From my point there are two different cases:
>  1) pts are out of order in some cases
>  2) broken streams can result in bad pts values
> 
> The code we removed could be used to fix 2).
> But 1) I do not see as broken stream data, instead it is a failure in
> demuxer/decoder to not provide correct pts with correct frame.

Any remotely reasonable fix for 2) would fix 1).
The point of -nocorrect-pts is to handle 2).
By fixing instead 1) you fix one specific symptom
of the bug while leaving the real bug untouched.