[MPlayer-dev-eng] [PATCH] add Opengl ES vo

[Reimar Döffinger]

On Thu, Nov 24, 2011 at 10:13:39PM +0100, Diego Biurrun wrote:
> On Wed, Nov 23, 2011 at 08:16:11PM +0100, Reimar Döffinger wrote:
> > On Wed, Nov 23, 2011 at 01:22:56PM +0100, Diego Biurrun wrote:
> > > On Wed, Nov 23, 2011 at 01:02:43PM +0100, kirin_e at users.sourceforge.net wrote:
> > > >
> > > > I needed OpenGL ES X11 output for a device i have so i ended up
> > > > writing a gles vo, here it is in case it's useful to others. Patch
> > > > against snapshot 2011-10-31, uses OpenGL ES 1.1 and currently needs
> > > > support for npot textures. Any comments or improvements are welcome.
> > > >
> > > > --- org/mplayer-export-2011-10-31/libvo/vo_gles.c       1970-01-01 01:00:00.000000000 +0100
> > > > +++ mplayer-export-2011-10-31/libvo/vo_gles.c   2011-11-23 03:52:53.000000000 +0100
> > > > @@ -0,0 +1,480 @@
> > > > +/*
> > > > + * This file is part of MPlayer.
> > > > + *
> > > > + * MPlayer is free software; you can redistribute it and/or modify
> > > > + * it under the terms of the GNU General Public License as published by
> > > > + * the Free Software Foundation; either version 2 of the License, or
> > > > + * (at your option) any later version.
> > > > + *
> > > > + * MPlayer is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License along
> > > > + * with MPlayer; if not, write to the Free Software Foundation, Inc.,
> > > > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > > > + *
> > > > + * You can alternatively redistribute this file and/or
> > > > + * modify it under the terms of the GNU Lesser General Public
> > > > + * License as published by the Free Software Foundation; either
> > > > + * version 2.1 of the License, or (at your option) any later version.
> > > > + */
> > > 
> > > This is pointless, read the LGPL §3 :)
> > > 
> > > You can always upgrade LGPL to any GPL version.  So just place this
> > > file under LGPL 2.1 to achieve what you want to.
> > 
> > Yes, but he can't place MPlayer under LGPL, which is what the text would
> > claim if you replaced the whole header the LGPL variant.
> > Which is why vo gl uses this convoluted text.
> 
> I disagree; LGPLing a file does not LGPL MPlayer nor claim it would.

If the text ends up saying
 MPlayer is free software; you can redistribute it and/or modify
 it under the terms of the LGPL
It sure as hell claims that MPlayer is LGPL, and not just that file.
it probably is quite irrelevant legally but I am not fine with having
nonsense in the license boilerplate, that kind of defeats the purpose
of having them in the first place (and IMHO is a lot worse than just
not having them at all).