[MPlayer-dev-eng] [PATCH]: vo_caca.c: use lookup_keymap_table()

Paul B. Mahol onemda at gmail.com
Thu Nov 24 20:12:02 CET 2011


On 11/24/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Thu, Nov 24, 2011 at 06:22:43PM +0000, Paul B. Mahol wrote:
>> On 11/24/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
>> > On Wed, Nov 23, 2011 at 08:27:28PM +0000, Paul B. Mahol wrote:
>> >> On 11/23/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
>> >> > On Fri, Nov 18, 2011 at 10:17:13PM +0000, Paul B. Mahol wrote:
>> >> >> On 11/18/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
>> >> >> > On Thu, Nov 10, 2011 at 02:19:41AM +0000, Paul B. Mahol wrote:
>> >> >> >> +        case CACA_KEY_F1:
>> >> >> >> +        case CACA_KEY_F2:
>> >> >> >> +        case CACA_KEY_F3:
>> >> >> >> +        case CACA_KEY_F4:
>> >> >> >> +        case CACA_KEY_F5:
>> >> >> >> +        case CACA_KEY_F6:
>> >> >> >> +        case CACA_KEY_F7:
>> >> >> >> +        case CACA_KEY_F8:
>> >> >> >> +        case CACA_KEY_F9:
>> >> >> >> +        case CACA_KEY_F10:
>> >> >> >> +        case CACA_KEY_F11:
>> >> >> >> +        case CACA_KEY_F12:
>> >> >> >> +        case CACA_KEY_F13:
>> >> >> >> +        case CACA_KEY_F14:
>> >> >> >> +        case CACA_KEY_F15:
>> >> >> >> +            mplayer_put_key(KEY_F + key - 0x119);
>> >
>> > I just realized (while reindenting) that that's a lot of case
>> > statements.
>> > IMO this really should be using lookup_keymap_table like x11/w32/sdl
>> > code does.
>> Done.
>
> Thanks, applied.
> I have to admit that the F key handling makes it a bit less nice
> than I had expected, though it's still an improvement IMO.
> Is there actually anyone with a keyboard with more than 12 F keys?
> (not that it matters, I was just kind of surprised, also you can't
> currently specify anything above F12 in the MPlayer config)

Some keyboards have them more than 15. SDL supports up to F15 and X11
(looking in keysymdef.h) much more.


More information about the MPlayer-dev-eng mailing list