[MPlayer-dev-eng] [PATCH]: vo_caca.c: improve mouse/keyboard handling

[Paul B. Mahol]

On 11/23/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Wed, Nov 23, 2011 at 08:27:28PM +0000, Paul B. Mahol wrote:
>> On 11/23/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
>> > On Fri, Nov 18, 2011 at 10:17:13PM +0000, Paul B. Mahol wrote:
>> >> On 11/18/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
>> >> > On Thu, Nov 10, 2011 at 02:19:41AM +0000, Paul B. Mahol wrote:
>> >> >> +        case CACA_KEY_F1:
>> >> >> +        case CACA_KEY_F2:
>> >> >> +        case CACA_KEY_F3:
>> >> >> +        case CACA_KEY_F4:
>> >> >> +        case CACA_KEY_F5:
>> >> >> +        case CACA_KEY_F6:
>> >> >> +        case CACA_KEY_F7:
>> >> >> +        case CACA_KEY_F8:
>> >> >> +        case CACA_KEY_F9:
>> >> >> +        case CACA_KEY_F10:
>> >> >> +        case CACA_KEY_F11:
>> >> >> +        case CACA_KEY_F12:
>> >> >> +        case CACA_KEY_F13:
>> >> >> +        case CACA_KEY_F14:
>> >> >> +        case CACA_KEY_F15:
>> >> >> +            mplayer_put_key(KEY_F + key - 0x119);
>> >> >
>> >> > Did you mean - CACA_KEY_F1? That hard-coded 0x119
>> >> > seems like a really bad idea.
>> >> > Looks good to me otherwise, except that the issue that
>> >> > at most one even is processed per check_events call still
>> >> > remains.
>> >>
>> >> Fixed both issues.
>> >
>> > Please don't put large reindentations in the same patch as functional
>> > changes, it is near impossible to figure out what changed.
>> > Also IMHO '\0' is a pointlessly obfuscated way of writing 0.
>>
>> Here is patch without reindentation.
>
> Why did you replace CACA_EVENT_KEY_RELEASE with
> CACA_EVENT_KEY_PRESS?
> All the mplayer_put_key calls in that case pass release
> events on, not press events.

Really? New behavior mimics other VOs like aa, sdl, x11.