[MPlayer-dev-eng] [PATCH]: vo_caca.c: improve mouse/keyboard handling

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Nov 18 18:17:22 CET 2011


On Thu, Nov 10, 2011 at 02:19:41AM +0000, Paul B. Mahol wrote:
> +        case CACA_KEY_F1:
> +        case CACA_KEY_F2:
> +        case CACA_KEY_F3:
> +        case CACA_KEY_F4:
> +        case CACA_KEY_F5:
> +        case CACA_KEY_F6:
> +        case CACA_KEY_F7:
> +        case CACA_KEY_F8:
> +        case CACA_KEY_F9:
> +        case CACA_KEY_F10:
> +        case CACA_KEY_F11:
> +        case CACA_KEY_F12:
> +        case CACA_KEY_F13:
> +        case CACA_KEY_F14:
> +        case CACA_KEY_F15:
> +            mplayer_put_key(KEY_F + key - 0x119);

Did you mean - CACA_KEY_F1? That hard-coded 0x119
seems like a really bad idea.
Looks good to me otherwise, except that the issue that
at most one even is processed per check_events call still
remains.


More information about the MPlayer-dev-eng mailing list