[MPlayer-dev-eng] [PATCH] fix direct3d crash on window minimization

[Alexander Strasser]

Hi

Roger Pack wrote:
> Alexander Strasser wrote:
[...]
> >  If the window is minimized the VO gets a resize event. When
> > handling the resize event, vo direct3d destroys the osd textures
> > and creates them again with a size fitting the new window size.
> >
> >  This works well normally, but fails in case of minimization
> > because then the sizes are 0 and the texture creation fails.
> > This causes the crash later when draw_osd() gets invoked.
> >
> >  I did not think about a proper solution yet.
> 
> Thanks for your attention to this, looking forward to a fix (or we
> could just use that patch as a work around or the like).

  I think the attached patch would be OK as a proper fix for the
problem. There could be other issues in certain corner cases, but
they were there before (if I did not make any mistake in my patch).

  I tested it while developing. Would be great if you or any other
users of vo direct3d could test it too and confirm it fixes the
issue and that it does not introduce regressions.

  If I hear no comlaints or objections from other developers I will
apply this in a few days. I pinged the maintainer already, but got
no reply yet. Still I think it is rather important to have this fixed
soon. (It is annoying if you can't minimize a video window because
a sub might be shown and it would crash).

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-vo_direct3d_osd_when_minimized.diff
Type: text/x-diff
Size: 903 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111113/cd223626/attachment.bin>