[MPlayer-dev-eng] [PATCH] fix direct3d crash on window minimization

[Alexander Strasser]

Hi!

Roger Pack wrote:
> Based off a patch from Patrick Dinh, this prevents mplayer from
> crashing when a direct3d window is minimized.
> 
> http://lists.mplayerhq.hu/pipermail/mplayer-users/2011-August/083097.html

  I could reproduce this:

  1. activate OSD or subtitles
  2. minimize the video window => segfault

  I also can confirm that the crash goes away with your patch applied.

> Feedback welcome, this is my first patch attempt.

  I am not familiar enough with vo direct3d to tell you if the patch
is a correct solution. The whole OSD rendering mechanism in vo direct3d
was a bit to complex for me to grasp immediately.

  But at the very least the comments are inaccurate after your patch is
applied. This in itself is a rather bad sign. Therefore the patch should
not be committed as is.

  How would you modify the comments after your change? No need to change
the patches yet! Just write us how you would extend the comments.

  Thanks for your work!

  Alexander